Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test misc expression #1272

Merged
merged 1 commit into from
Jan 7, 2025
Merged

test misc expression #1272

merged 1 commit into from
Jan 7, 2025

Conversation

Hecate2
Copy link
Contributor

@Hecate2 Hecate2 commented Jan 3, 2025 •
edited
Loading 

int a = 0;
a = a++;  // typically it should be just a++;
a = ++a;

The behavior of expressions above are not clearly defined (both in C# and in our devpack), but not a big problem for now.

@Hecate2 Hecate2 force-pushed the test-misc-expression branch from b2e07dc to 8add0ba Compare January 3, 2025 07:04
@Jim8y
Copy link
Contributor

Jim8y commented Jan 3, 2025

This pr is not related to a=a++;?

@Jim8y Jim8y requested review from shargon and nan01ab January 3, 2025 07:23
@Hecate2
Copy link
Contributor Author

Hecate2 commented Jan 3, 2025 •
edited
Loading

This pr is not related to a=a++;?

I did not change any behavior of the compiler, but I wrote tests for a=a++;. It behaves the same as C#, but I am not sure whether this is correct.

@Jim8y Jim8y merged commit c7c5a2c into neo-project:master Jan 7, 2025
4 checks passed
@Hecate2 Hecate2 deleted the test-misc-expression branch January 10, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@nan01ab nan01ab nan01ab approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hecate2 @Jim8y @shargon @nan01ab @vncoelho